Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up zopen build env processing #592

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Speed up zopen build env processing #592

wants to merge 3 commits into from

Conversation

IgorTodorovskiIBM
Copy link
Collaborator

@IgorTodorovskiIBM IgorTodorovskiIBM commented Nov 22, 2023 •
edited
Loading

  • Source the .appenv rather than the .env in zopen-build
  • Append the paths to PATH/LIBPATH
  • Sets project _HOME environment variables

Tested with git, vim, bash and curl

  • Also includes an unrelated fix to zopen-generate thanks to Gaby

@IgorTodorovskiIBM
Copy link
Collaborator Author

IgorTodorovskiIBM commented Nov 22, 2023 •
edited
Loading

Discovered an issue with it NOT pulling in runtime dependencies

@IgorTodorovskiIBM IgorTodorovskiIBM marked this pull request as draft November 22, 2023 14:38
@IgorTodorovskiIBM
Copy link
Collaborator Author

/run tests

6 similar comments
@IgorTodorovskiIBM
Copy link
Collaborator Author

/run tests

@IgorTodorovskiIBM
Copy link
Collaborator Author

/run tests

@IgorTodorovskiIBM
Copy link
Collaborator Author

/run tests

@IgorTodorovskiIBM
Copy link
Collaborator Author

/run tests

@IgorTodorovskiIBM
Copy link
Collaborator Author

/run tests

@IgorTodorovskiIBM
Copy link
Collaborator Author

/run tests

MikeFultonDev
MikeFultonDev approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@MikeFultonDev MikeFultonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeFultonDev MikeFultonDev MikeFultonDev approved these changes

@DevonianTeuchter DevonianTeuchter Awaiting requested review from DevonianTeuchter DevonianTeuchter is a code owner

@HarithaIBM HarithaIBM Awaiting requested review from HarithaIBM HarithaIBM is a code owner

@v1gnesh v1gnesh Awaiting requested review from v1gnesh v1gnesh will be requested when the pull request is marked ready for review v1gnesh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorTodorovskiIBM @MikeFultonDev