Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Bool required field to be False if unset #107

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Revert Bool required field to be False if unset #107

merged 1 commit into from
Aug 20, 2021

Conversation

jensens
Copy link
Member

@jensens jensens commented Aug 19, 2021

See #104 (around the reopen) for details.

mauritsvanrees
mauritsvanrees approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirm this fixes the problem I had with collective.easyform.

@jensens jensens merged commit da652e1 into master Aug 20, 2021
@jensens jensens deleted the revert-parts-of-105 branch August 20, 2021 09:07
@petschki petschki mentioned this pull request Oct 8, 2021
Open
1 task
@frapell frapell mentioned this pull request Jan 12, 2022
Closed
@petschki petschki mentioned this pull request Jul 17, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

@agitator agitator Awaiting requested review from agitator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jensens @mauritsvanrees