Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set the boolean required attribute as required. #118

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Don't set the boolean required attribute as required. #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cce411
Don't set the boolean required attribute as required.
thet Jul 17, 2023
22c21e0
Merge branch 'master' into no-bool-required
Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ Changelog
5.1 (unreleased)
----------------

- Don't set the boolean required attribute as required.
Boolean attributes with a default value which do not have to be set to true
should not be marked as required attributes.

- HTMLFormElement.attributes: Allow to extend HTML attributes programmatically.


Expand Down
2 changes: 1 addition & 1 deletion src/z3c/form/interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ class IWidget(ILocation):
description=_('If true the widget should be displayed as required '
'input.'),
default=False,
required=True)
required=False)

error = zope.schema.Field(
title=_('Error'),
Expand Down
Loading