HTMLFormElement.addClass: Improve removal of duplicates. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
force-pushed
the
addclass-improvement
branch
from
d625b2e
to
ad1a6e1
Compare
icemac
reviewed
Jul 14, 2023
It's now possible to add multiple classes as whitespace separated string and still detect class duplicates.
thet
force-pushed
the
addclass-improvement
branch
from
ad1a6e1
to
ebb0035
Compare
gforcada
approved these changes
Jul 14, 2023
icemac
approved these changes
Jul 17, 2023
|
I just released https://pypi.org/project/z3c.form/5.0/ containing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now possible to add multiple classes as whitespace separated string and still detect class duplicates.
Note: this introduces also typehinting on the
addClassmethod. But we're on Python 3.7+ and that should be ok...