Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow default dialog alert #4100

Merged
merged 12 commits into from
Oct 24, 2017
Merged

Workflow default dialog alert #4100

merged 12 commits into from
Oct 24, 2017

Commits on Oct 17, 2017

  1. WIP: Add modal warning for removal of default workflow.

    @jelliotartz
    jelliotartz committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    d2f9a3e View commit details
    Browse the repository at this point in the history

  2. Refactor to use Promise.all() for requests.

    @jelliotartz
    jelliotartz committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    79a8bee View commit details
    Browse the repository at this point in the history

  3. Cleanup linter errors.

    @jelliotartz
    jelliotartz committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    b1f82a1 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for WorkflowDefaultDialog.

    @jelliotartz
    jelliotartz committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    335c892 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2017

  1. Address requested changes. 

    - Remove Translation component and unused code.
- Use Promise.all for update requests.
- Add class method for wrkflow & proj GET req's.
- Move WorkflowDefaultDialog to admin folder.
    @jelliotartz
    jelliotartz committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    67ddefd View commit details
    Browse the repository at this point in the history

  2. Bind getProjectAndWorkflows() in constructor.

    @jelliotartz
    jelliotartz committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    d420426 View commit details
    Browse the repository at this point in the history

  3. Address requested changes. 

    - Move promises object inside .then() block of Dialog.alert.
- Add catch block for updating workflow status request.
- Update modal text.
- Remove test for modal text content.
    @jelliotartz
    jelliotartz committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    d436d4f View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2017

  1. WIP: manually handle modal form open/close state.

    @jelliotartz
    jelliotartz committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    3643627 View commit details
    Browse the repository at this point in the history

  2. Fix broken test. Close dialog in successful promise.

    @jelliotartz
    jelliotartz committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    e32fbd0 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2017

  1. Address requested changes 

    - Refactor handleDialogSuccess to remove Promise.all()
- Update error rendering to display status and msg from error obj.
- Update modal UI to separate buttons from text with <p>.
- Remove button ids, target via first() and last() for tests.
- Fix linter errors.
    @jelliotartz
    jelliotartz committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    c334028 View commit details
    Browse the repository at this point in the history

  2. Get defaultWorkflowId from state.

    @jelliotartz
    jelliotartz committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    52c8723 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2017

  1. Refactor defaultWorkflow filter.

    @jelliotartz
    jelliotartz committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    c1d030c View commit details
    Browse the repository at this point in the history