Remove Arity check that does not work with ActiveRecord objects #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The save method a standard ActiveRecord object has an Arity of -1, not 1 as expected by this code. ``` User.first.method(:save).arity > -1 ``` The effect is that when we pass in a validation context it is not used.
|
Is there any chance of getting this merged? Having the validation context work for ActiveRecord objects would be really useful (and is probably the majority of use cases, as @MichaelDowse suggests)! One minor suggestion: would it be more correct to keep the Arity check, but amend it to |
|
Thanks! |
|
Could this be released as a version bump? |
|
I released 1.3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The save method a standard ActiveRecord object has an Arity of -1, not 1 as expected by this code.
The effect is that when we pass in a validation context it is not used.
Removing the check means that it works by default for ActiveRecord objects which is the main use of Wicked, and the only known use of the context option.