Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rails 6 support #47

Closed

Conversation

prathamesh-sonpatki
Copy link
Collaborator

No description provided.

@schneems
Copy link
Member

schneems commented Oct 2, 2019

I ported over your code and got it across the finish line here #50

Thanks a ton for your work! The missing pieces were that when creating the new template object we have to pass in source, and strangely enough the html templates' format is now nil instead of :html. There might be a bug in our code somewhere causing that but it was easier to flip the logic and check for not :text.

@schneems schneems closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants