Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add support for python 3.11 and drop support for 3.7 #121

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Mar 9, 2023

@zoj613 zoj613 added maintainance maintaince of exisiting code. CI/CD labels Mar 9, 2023
Copy link

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pin a specific version of numpy? Can it be a minimum?

@zoj613
Copy link
Owner Author

zoj613 commented Mar 9, 2023

Why pin a specific version of numpy? Can it be a minimum?

Which part are you referring to? There is a pinned version of numpy for building and one for development.

  1. Its important to pin the version to the lowest numpy version supported by a particular version of python. This is strongly encouraged by the numpy/scipy dev teams as well. Also see: https://numpy.org/neps/nep-0029-deprecation_policy.html
  2. Pinning the numpy development version to the version installable in all supported python version seems sensible to ensure consistent behavior.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7bbba58) 100.00% compared to head (4c76a7c) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #121    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1         2     +1     
  Lines            2       135   +133     
==========================================
+ Hits             2       135   +133     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ricardoV94
Copy link

In the pyproject, aren't you forcing a specific numpy version when installing the package with python 3.11? Instead of just a minimum version?

The reason I am asking is that other libraries might have also specific numpy requirements, not just because they test with it but because they actually need it (eg numba) which could unnecessarily become incompatible with this one.

Or am I missing something?

@ricardoV94
Copy link

Ah is it just for building the wheels?

@zoj613
Copy link
Owner Author

zoj613 commented Mar 9, 2023

Ah is it just for building the wheels?

Yes, thats only for building the wheels since as I mentioned in the 2 points above that it must be done with the lowest supported numpy version for that particular version of python. For normal installation the lines

requires-python = ">=3.8"
dependencies = ["numpy >= 1.19.0"]

Are the only ones that matter.

@ricardoV94
Copy link

Nice, apologies for the confusion.

@zoj613 zoj613 force-pushed the python-311-support branch 2 times, most recently from 27cef7d to a124109 Compare March 9, 2023 23:41
@zoj613
Copy link
Owner Author

zoj613 commented Mar 9, 2023

The tests pass, but it looks like codecov is broken all of sudden and wont upload the code coverage report and thus failing the entire CI pipeline.

@zoj613 zoj613 changed the title Add support for python 3.11 and drop support for 3.7 MAINT: Add support for python 3.11 and drop support for 3.7 Mar 10, 2023
@zoj613 zoj613 merged commit afe0e7d into main Mar 10, 2023
@zoj613 zoj613 deleted the python-311-support branch March 10, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD maintainance maintaince of exisiting code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants