-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Add support for python 3.11 and drop support for 3.7 #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why pin a specific version of numpy? Can it be a minimum?
Which part are you referring to? There is a pinned version of numpy for building and one for development.
|
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 1 2 +1
Lines 2 135 +133
==========================================
+ Hits 2 135 +133 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
In the pyproject, aren't you forcing a specific numpy version when installing the package with python 3.11? Instead of just a minimum version? The reason I am asking is that other libraries might have also specific numpy requirements, not just because they test with it but because they actually need it (eg numba) which could unnecessarily become incompatible with this one. Or am I missing something? |
Ah is it just for building the wheels? |
Yes, thats only for building the wheels since as I mentioned in the 2 points above that it must be done with the lowest supported numpy version for that particular version of python. For normal installation the lines requires-python = ">=3.8"
dependencies = ["numpy >= 1.19.0"] Are the only ones that matter. |
Nice, apologies for the confusion. |
27cef7d
to
a124109
Compare
The tests pass, but it looks like codecov is broken all of sudden and wont upload the code coverage report and thus failing the entire CI pipeline. |
4c76a7c
to
c8f0f56
Compare
c8f0f56
to
32daafb
Compare
Cc @ricardoV94