Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for Python 3.11 #6584

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Mar 9, 2023

Many people have been installing PyMC on Python 3.11. Checking if all of our tests pass on it, before adding it as an explicit supported version.

Last commit should be dropped before merging

Related to pymc-devs/pytensor#198

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #6584 (693be05) into main (49aacf4) will decrease coverage by 0.14%.
The diff coverage is 91.52%.

❗ Current head 693be05 differs from pull request most recent head ecb6a37. Consider uploading reports for the commit ecb6a37 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6584      +/-   ##
==========================================
- Coverage   92.01%   91.87%   -0.14%     
==========================================
  Files          91       92       +1     
  Lines       15114    15533     +419     
==========================================
+ Hits        13907    14271     +364     
- Misses       1207     1262      +55     
Impacted Files Coverage Δ
pymc/testing.py 91.92% <91.52%> (ø)

... and 5 files with indirect coverage changes

@ricardoV94
Copy link
Member Author

@zoj613 The Polyagamma library was causing conflicts with Python3.11 due to numpy dependencies. Have you seen/tested that?

@zoj613
Copy link
Contributor

zoj613 commented Mar 9, 2023

@zoj613 The Polyagamma library was causing conflicts with Python3.11 due to numpy dependencies. Have you seen/tested that?

Could you show me the error message? The tests currently are for python 3.7-3.10. polyagamma-feeedstock pushed a conda build for 3.11 a while back. See conda-forge/polyagamma-feedstock#10

@ricardoV94 ricardoV94 force-pushed the test_py311 branch 2 times, most recently from 693be05 to 8178c66 Compare March 9, 2023 18:29
@ricardoV94
Copy link
Member Author

@zoj613 I removed the last commit, it should fail again now

@ricardoV94
Copy link
Member Author

https://github.com/pymc-devs/pymc/actions/runs/4377616124/jobs/7661318215

@zoj613
Copy link
Contributor

zoj613 commented Mar 9, 2023

pymc-devs/pymc/actions/runs/4377616124/jobs/7661318215

Thanks. Gonna take a look at this sometime today.

@zoj613
Copy link
Contributor

zoj613 commented Mar 9, 2023

See zoj613/polyagamma#121

@zoj613
Copy link
Contributor

zoj613 commented Mar 10, 2023

@ricardoV94 v1.3.5 with py3.11 support is up on pypi. You can retry the CI.

@ricardoV94 ricardoV94 marked this pull request as ready for review March 10, 2023 13:47
@ricardoV94
Copy link
Member Author

All tests passed with Python 3.11, reverting now the commit so jobs are spread across multiple versions as before

@ricardoV94 ricardoV94 merged commit 5603792 into pymc-devs:main Mar 10, 2023
@ricardoV94 ricardoV94 deleted the test_py311 branch June 6, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants