WIP: feature/access_logs #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md --> Added region configuration, corrected typos, added information regarding access logs s3.tf --> added S3 bucket configuration to store the access logs variables_load_balancer_access_logs.tf --> variables required for the access logs
|
@derBroBro Updated testing tf file in google drive. Note: Change logs? |
|
Blocker for pull request: Terraform itself needs a change to support access logs as disabled. Bug: When in the access logs block "enabled=false" is set, due to the access log block existing, it forces terraform to configure access logs... |
|
Definitely merge this back to the public module if you find a workaround! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alb.tf --> enabled access logging
README.md --> Added region configuration, corrected typos, added information regarding access logs
s3.tf --> added S3 bucket configuration to store the access logs
variables_load_balancer_access_logs.tf --> variables required for the access logs