Defer manylinux builds until tests pass; these builds are just doing …

…a compilation, no testing.
zodb · Jun 27, 2023 · 8162ca0 · 8162ca0
1 parent 527e7bf
commit 8162ca0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -227,6 +227,7 @@ jobs:
           parallel-finished: true
 
   manylinux:
+    needs: test
     runs-on: ubuntu-latest
     # We use a regular Python matrix entry to share as much code as possible.
     strategy:

diff --git a/src/relstorage/adapters/mysql/drivers/mysqlconnector.py b/src/relstorage/adapters/mysql/drivers/mysqlconnector.py
@@ -120,12 +120,8 @@ def _get_converter_class(cls):
             # XXX: It's possible this area is where the problems on
             # mysql.connector >= 8.0.33 are introduced.
             class BlobConverter(mysql.connector.conversion.MySQLConverter):
-
-                def __init__(self, charset_name, use_unicode):
-                    super().__init__(charset_name, use_unicode)
-
                 # There are a few places we get into trouble on
-                # Python 2/3 with bytearrays comping back: they
+                # Python 2/3 with bytearrays coming back: they
                 # can't be hashed for the local_client compression
                 # functions or sent to zlib.decompress(), they
                 # can't be sent to pickle.loads(), etc, so it's