Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle configuration property #684

Merged
merged 5 commits into from
Mar 27, 2018

Conversation

superandrew213
Copy link
Contributor

Fixes #682

@christocracy
Copy link

@superandrew213 Don't stop at only adding googlePlayServicesVersion -- Add properties for supportLibVersion, compileSdkVersion, targetSdkVersion and buildToolsVersion

@see my PR at react-native-maps

@lfkwtz
Copy link
Contributor

lfkwtz commented Mar 26, 2018

Updated this PR on #690 thanks to @christocracy

@superandrew213
Copy link
Contributor Author

@lfkwtz no need to create a new PR. Just updated mine.

@superandrew213
Copy link
Contributor Author

@zo0r do you have some time to take a quick look at this and merge? It's pretty straight forward.

@Rah1x
Copy link

Rah1x commented Mar 28, 2018

may be you can update the version of the module at npmjs as well. Im still getting 3.0.2 and it doesnt have the latest changes. I did the npm uninstall and did the install again still getting the old build.gradle.

npm show react-native-push-notification version
still shows 3.0.2

https://www.npmjs.com/package/react-native-push-notification

@lfkwtz
Copy link
Contributor

lfkwtz commented Apr 2, 2018

@zo0r can you do an npm publish?

@Rah1x
Copy link

Rah1x commented Apr 3, 2018

I guess the only way to get the latest version for now is to install directly from git:
npm install git+https://github.com/zo0r/react-native-push-notification.git

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants