Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't require model file for verifier #216

Merged
merged 25 commits into from
May 3, 2023

Conversation

alexander-camuto
Copy link
Collaborator

@alexander-camuto alexander-camuto commented May 2, 2023

Recent updates in #208 mean that ModelCircuit can be configured using a params object. Here we serialize this object and pass it to verifying functions such that the verifier no longer requires a model onnx file : )

verify commands just require a --circuit-params-path flag pointing to a serialized ModelParams struct, which holds the following information:

/// model parameters
#[derive(Clone, Debug, Default, Serialize, Deserialize)]
pub struct ModelParams {
    /// run args
    pub run_args: RunArgs,
    /// the visibility of the variables in the circuit
    pub visibility: VarVisibility,
    /// the potential number of constraints in the circuit
    pub num_constraints: usize,
    /// the shape of public inputs to the circuit (in order of appearance)
    pub instance_shapes: Vec<Vec<usize>>,
    /// required_lookups
    pub required_lookups: Vec<LookupOp>,
}

@alexander-camuto alexander-camuto marked this pull request as ready for review May 3, 2023 07:17
@alexander-camuto alexander-camuto merged commit 880af12 into main May 3, 2023
@alexander-camuto alexander-camuto deleted the ac/wasm-bindgen-verifier branch May 3, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant