Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure ModelCircuit with params #208

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

alexander-camuto
Copy link
Collaborator

@alexander-camuto alexander-camuto commented Apr 27, 2023

Recent improvements in privacy-scaling-explorations/halo2#168 mean we may be able to persist params without the repeated calls to from_arg() + will help with python bindings.

Here we:

  • compile halo2 with the params feature
  • implement the configure_with_params method in ModelCircuit
  • instantiate the circuit params when calling new.

@alexander-camuto alexander-camuto marked this pull request as ready for review April 27, 2023 12:34
@alexander-camuto alexander-camuto merged commit fbb16c6 into main Apr 27, 2023
@alexander-camuto alexander-camuto deleted the ac/configure-with-params branch April 27, 2023 12:34
@alexander-camuto alexander-camuto restored the ac/configure-with-params branch April 27, 2023 12:34
@alexander-camuto alexander-camuto deleted the ac/configure-with-params branch April 27, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant