Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to criterion 0.5 #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rillian
Copy link

@rillian rillian commented Feb 1, 2024

Port to the current release of the criterion benchmark harness to address cargo audit warnings about transitive dependencies. The benchmark_function_with_inputs API has been deprecated since 0.3 and is removed in 0.4 and most benchmarks must therefore be ported to the new BenchmarkGroup type.

Resolves

Port to the current release of the `criterion` benchmark harness
to address `cargo audit` warnings about transitive dependencies.
The `benchmark_function_with_inputs` API has been deprecated
since 0.3 and is removed in 0.4 and most benchmarks must
therefore be ported to the new `BenchmarkGroup` type.

Resolves
- https://rustsec.org/advisories/RUSTSEC-2021-0127
- https://rustsec.org/advisories/RUSTSEC-2021-0145
@rillian
Copy link
Author

rillian commented Feb 1, 2024

NB submitted this against main, since it looks like that's where current work is happening, although CONTRIBUTING.md specifies develop for new work like the original dalek repo.

Similar to dalek-cryptography#375 and brave-experiments#1.

Run `cargo fmt` to regularize new changes, per github actions gate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant