-
-
Notifications
You must be signed in to change notification settings - Fork 105
Windows: npx is not escaping paths correctly #84
Comments
Right. What if |
I think that's what needs to be done, yeah. |
Thanks a lot for keeping on this! Pointing out the obvious but just so you know for certain what my setup looks like: Node is located at C:\Program Files\nodejs\node.exe (spaces in path) |
Let's see if #87 works now? |
It's working fine for me. Works in both cmd.exe and git bash. Since my |
Nice! =) Thank you kindly, @zkat and @katemihalikova! |
@zkat, sorry, quick note for the back of your mind: Looks like it should say "installed 5 packages in 21.205s.", yes? |
lol probably, but adding a single word to that string involves updating 17 other translations, many to languages I don't even know how to touch 😂 |
And pluralization. =P |
@aivo0 for information, I solved it by upgrading to node v8.12.0 |
Ref: #62 (comment)
I'm confused 'cause this should totally be the right way to escape things for
child_process.exec
. Note thatC:\"Program Files"\...
is there, which should be the way to escape paths on Windows.I'm thinking it's possible that this sort of escaping only applies when you're dealing with the binary path itself, and arguments don't get processed the same way and thus need to be escaped as args?
The text was updated successfully, but these errors were encountered: