fix missing absolute path resolution in glob version #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinserjan
changed the title
zinserjan
changed the title
zinserjan
changed the title
Current coverage is 94.60% (diff: 100%)@@ master #106 diff @@
==========================================
Files 26 26
Lines 721 723 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 682 684 +2
Misses 39 39
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mocha-webpack needs
globin version 7.1.0 to get the absolute path option, but the version range forglobinglobbyis just^7.0.3which matches also versions before 7.1.0.This leads to issues with npm@3's flat dependency tree.
The fastest fix is that we don't rely on the absolute path option.