Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds testing #12

Merged
merged 6 commits into from
Nov 20, 2021
Merged

Adds testing #12

merged 6 commits into from
Nov 20, 2021

Conversation

zgosalvez
Copy link
Owner

Potentially resolves #10 and #11.

Copy link
Contributor

@nackerman-nydig nackerman-nydig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't pull down and test, but just giving it an "eye-ball pass" looks good

@zgosalvez zgosalvez linked an issue Nov 10, 2021 that may be closed by this pull request
@xunleii
Copy link
Contributor

xunleii commented Nov 11, 2021

@zgosalvez I have this following error when I run your tests:

 FAIL  test/fail.test.js
  ● action has empty error

    expect(received).toContain(expected) // indexOf

    Expected substring: "Cannot read property 'jobs' of null"
    Received string:    "::debug::followSymbolicLinks 'true'
    ::debug::implicitDescendants 'true'
    ::debug::omitBrokenSymbolicLinks 'true'
    ::debug::Search path '***/github-actions-ensure-sha-pinned-actions/test/stub/empty'
    ::error::Cannot read properties of null (reading 'jobs')
    "

      21 |         const result = error.stdout.toString();
      22 |
    > 23 |         jest.expect(result).toContain('Cannot read property \'jobs\' of null');
         |                             ^
      24 |         jest.expect(result).not.toContain('No issues were found.');
      25 |     }
      26 | });

      at Object.<anonymous> (test/fail.test.js:23:29)

 PASS  test/pass.test.js

Test Suites: 1 failed, 1 passed, 2 total
Tests:       1 failed, 2 passed, 3 total
Snapshots:   0 total
Time:        0.441 s, estimated 1 s

@zgosalvez zgosalvez merged commit 0b552a1 into main Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants