Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with shared Github Actions workflows #4

Closed
xunleii opened this issue Oct 6, 2021 · 2 comments · Fixed by #7
Closed

Issues with shared Github Actions workflows #4

xunleii opened this issue Oct 6, 2021 · 2 comments · Fixed by #7

Comments

@xunleii
Copy link
Contributor

xunleii commented Oct 6, 2021

Hi @zgosalvez

Firstly, thanks a lot for this Action, I use it every day.

I'm currently sharing my day-to-day workflows on a this repository and your Action currently fails with the new syntax (see https://docs.github.com/en/actions/learn-github-actions/reusing-workflows#calling-a-reusable-workflow) (if you need more information, here is the failed job).
Furthermore, I think we can ensure that theses shared workflow should be pinned like other uses fields.

@zgosalvez
Copy link
Owner

Finally, GitHub allows for reusing workflows. This is very new, and I'll need time to learn the changes and review the code to support the new syntax. Hopefully, we can have version 2 released soon, but any PR is welcome!

@xunleii
Copy link
Contributor Author

xunleii commented Oct 9, 2021

@zgosalvez I made a PR to add compatibility with this new Github feature

zgosalvez added a commit that referenced this issue Oct 31, 2021
* feat: checks pinned version for job.uses

* fix: checks SHA only if the step contains `uses`

* Minor formatting fixes

Co-authored-by: Zennon Gosalvez <1798166+zgosalvez@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants