Fix "last step wins" error (#132)

* Add a test case that has a pinned action after an un-pinned one Whether the job fails or not was being overwritten by the last step in the job. If the last step is pinned, this would cause the check to pass, even if an earlier step was unpinned. Now we have a test case that exercises this functionality. * Fail the job if any steps have errors Previously this logic only failed the job if the last step had an error. * Run npm prepare --------- Co-authored-by: Zennon Gosalvez <1798166+zgosalvez@users.noreply.github.com>
zgosalvez · Dec 3, 2023 · b1b635d · b1b635d
1 parent 0cee947
commit b1b635d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/index.js b/src/index.js
@@ -37,7 +37,7 @@ async function run() {
           jobHasError = runAssertions(uses, allowlist, isDryRun);
         } else if (steps !== undefined) {
           for (const step of steps) {
-            jobHasError = runAssertions(step['uses'], allowlist, isDryRun);
+            jobHasError ||= runAssertions(step['uses'], allowlist, isDryRun);
           }
         } else {
           core.warning(`The "${job}" job of the "${basename}" workflow does not contain uses or steps.`);  

diff --git a/test/stub/unpinned/file.yaml b/test/stub/unpinned/file.yaml
@@ -6,3 +6,8 @@ jobs:
     steps:
       - uses: docker://rhysd/actionlint:latest
       - uses: docker://rhysd/actionlint:1.6.22
+  mixedstub:
+    steps:
+      - uses: actions/checkout@v1
+      - uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
+