Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure __module__ is fine on node class creation #739

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Apr 8, 2024

Small change to ensure that the __module__ variable is set as expected on creation of a node class from a function.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.85%. Comparing base (1f429c3) to head (620e7d6).

Files Patch % Lines
src/sisl/nodes/tests/test_node.py 77.77% 2 Missing ⚠️
src/sisl/nodes/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files         408      408           
  Lines       51688    51696    +8     
=======================================
+ Hits        44896    44903    +7     
- Misses       6792     6793    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit 0bdca4d into zerothi:main Apr 8, 2024
8 of 9 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants