Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add function for adding file descriptor to poller_t #595

Merged
merged 2 commits into from
Jun 9, 2023
Merged

add function for adding file descriptor to poller_t #595

merged 2 commits into from
Jun 9, 2023

Conversation

uyha
Copy link
Contributor

@uyha uyha commented Jun 7, 2023

Fix #557

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5201493977

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.251%
Totals Coverage Status
Change from base Build 5121755673: 0.0%
Covered Lines: 803
Relevant Lines: 931
💛 - Coveralls

@uyha
Copy link
Contributor Author

uyha commented Jun 8, 2023

@gummif I don't think the runners are gonna pick this up 😅
image

@uyha
Copy link
Contributor Author

uyha commented Jun 8, 2023

it seems like Github discontinued ubuntu-18.04, it's not listed in here anymore.

@gummif
Copy link
Member

gummif commented Jun 9, 2023

Ok thanks, will fix that later.

@gummif gummif merged commit 9a655c1 into zeromq:master Jun 9, 2023
10 of 13 checks passed
@uyha uyha deleted the poller-fd branch June 9, 2023 13:01
@uyha uyha mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

poller_t and file descriptors (and why draft api)
3 participants
@uyha @coveralls @gummif