New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes warning noexcept #581

Merged

gummif merged 2 commits into zeromq:master from ThibaultDECO:patch-1

Oct 16, 2022

Contributor

ThibaultDECO commented Oct 14, 2022

This type of function should not throw, adding noexcept


          Fixes warning

fa0f112

This type of function should not throw, adding noexcept

coveralls commented Oct 14, 2022 •

edited

Loading

Pull Request Test Coverage Report for Build 3256135122

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.251%

Totals
Change from base Build 3222337817:	0.0%
Covered Lines:	803
Relevant Lines:	931

💛 - Coveralls

Member

gummif commented Oct 14, 2022

You must use the ZMQ_NOTHROW macro instead of noexcept for compatibility.


          ZMQ_NOTHROW for compatibility

6020e1a

Contributor Author

ThibaultDECO commented Oct 15, 2022

Done, thanks!

Member

gummif commented Oct 16, 2022

Thanks

gummif merged commit c66fc60 into zeromq:master

ThibaultDECO deleted the patch-1 branch

December 6, 2022 13:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment