New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: poll default timeout is deprecated #497

Merged

bluca merged 2 commits into master from gfa/pollms

Aug 13, 2021

Member

gummif commented Jun 29, 2021

Solution: default to std::chrono::milliseconds

gummif mentioned this pull request

Deprecation of poll(std::vector<zmq_pollitem_t> &items) #494

Closed


          Problem: poll default timeout is deprecated

7aa3f37

Solution: default to std::chrono::milliseconds

gummif force-pushed the gfa/pollms branch from 46f5916 to 7aa3f37 Compare

July 14, 2021 22:46


          Call non-deprecated functions in implementation

2b466a6

Member Author

gummif commented Aug 13, 2021

@sigiesec @bluca What is best practice regarding PRs here, should I ping you for review?

bluca merged commit 180fbcc into master

bluca deleted the gfa/pollms branch

August 13, 2021 14:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment