Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: zmq_fd_t not used/available in zmq #452

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

gummif
Copy link
Member

@gummif gummif commented Oct 10, 2020

Solution: Make zmq::fd_t available and use in poller_event

This is currently available as zmq::sockopt::cppzmq_fd_t, so this is techincally a breaking change. I could add a typedef there for backward compatibility reasons if requested.

@sigiesec
Copy link
Member

This is currently available as zmq::sockopt::cppzmq_fd_t, so this is techincally a breaking change. I could add a typedef there for backward compatibility reasons if requested.

Yes, please add a typedef. It's easy to avoid breakage that way, so even if it's unlikely, we should do that. You might add a comment that using zmq::fd_t is preferred. (I think ZMQ_DEPRECATED doesn't work there?)

Solution: Make zmq::fd_t available and use in poller_event
@sigiesec
Copy link
Member

This is still breaking the Windows builds at

  C:\projects\cppzmq\zmq.hpp(1398): error C2062: type 'int' unexpected [C:\projects\cppzmq\Build\tests\unit_tests.vcxproj]

Could you give that another look?

@gummif
Copy link
Member Author

gummif commented Feb 12, 2021

Finally took a look at this, don't know if there is a good way to do this so just used a comment.

@sigiesec sigiesec merged commit f428fee into zeromq:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants