-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: message_t ctor string inconsistency #399
Conversation
Sorry I am lagging behind somewhat. I will try to give this and your other PRs a closer look in the next days. Is there one particularly urgent? |
Alright, nothing urgent, just minor fixes. |
I still have some problems digesting this rather large PR. Unfortunately, the commits are not self-contained, as some of them fix issues from earlier commits. Is it possible to break this up into some self-contained steps, and rewrite the commits accordingly, in a way that would simplify review? Is all of this really necessary to fix the issue from #396? (Not saying that the changes shouldn't be done, I am just trying to understand if there is one part fixing #396 and more things that are additional improvements) |
I am going to split the unrelated changes into other PRs (see e.g. #416) before the rewrite. |
bf61392
to
7c9a79e
Compare
This has been simplified a lot and is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, now it was must easier to review this :)
Solution: Constuctor taking generic ranges including string literals includes the null terminated char in the message. Deprecate function and add overloads for strings.
7c9a79e
to
ae570b0
Compare
Solution: Constructor taking generic ranges including string literals includes the null terminated char in
the message. Deprecate function and add overloads for strings.
This fixes the root cause of a problem observed in #396 and discussed here #397