Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Invalid 32bit issues when using Conan #374

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

gummif
Copy link
Member

@gummif gummif commented Jan 15, 2020

Solution: Remove architechture checks from cmake version file

Since this is a header only library there is no need to check for 32 vs 64bits.

See similar problem: doctest/doctest#225

Solution: Remove architechture checks from cmake version file

Since this is a header only library there is no need to check for 32 vs 64bits.

See similar problem: doctest/doctest#225
@coveralls
Copy link

coveralls commented Jan 15, 2020

Pull Request Test Coverage Report for Build 313

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.558%

Totals Coverage Status
Change from base Build 311: 0.0%
Covered Lines: 689
Relevant Lines: 796

💛 - Coveralls

@sigiesec
Copy link
Member

It's not that obvious why this is necessary. Could you maybe extend the comment so that this can be understood easier, and the risk someone removes it accidentally again is reduced? I think this is quite a nice explanation: https://github.com/catchorg/Catch2/blob/master/CMakeLists.txt#L140

@sigiesec
Copy link
Member

Thanks!

@sigiesec sigiesec merged commit 8d5c9a8 into zeromq:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants