Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Coverage with coveralls not working #247

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

kurdybacha
Copy link
Contributor

Solution: Enable coveralls for one linux build target and fix coveralls
configuration.

Solution: Enable coveralls for one linux build target and fix coveralls
configuration.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 115

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+22.0%) to 85.673%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 30 78.54%
Totals Coverage Status
Change from base Build 113: 22.0%
Covered Lines: 293
Relevant Lines: 342

💛 - Coveralls

@c-rack c-rack merged commit edc14b6 into zeromq:master Jun 4, 2018
@kurdybacha kurdybacha deleted the coveralls branch June 4, 2018 12:24
@sigiesec
Copy link
Member

sigiesec commented Jun 4, 2018

@kurdybacha Thanks a lot for working on this. Unfortunately, it is still not right. For example, https://coveralls.io/builds/17296150/source?filename=zmq.hpp#L737 is still not shown as uncovered. Indeed, I think (almost?) all functions that are not used do not appear in the coverage report. I tried a bit around with lcov to get this working, following the hints at https://stackoverflow.com/a/19792966, but it did not work out either :(

@kurdybacha
Copy link
Contributor Author

Yes, it is still broken :( will take a look again on this. Thanks for the link, it might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants