Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cmake build succeeds even if libzmq not found #243

Merged
merged 1 commit into from
May 25, 2018

Conversation

sigiesec
Copy link
Member

Solution: raise a FATAL_ERROR if not found, and improve diagnostic output

Catches the error reported in #241 already during cmake run

Solution: raise a FATAL_ERROR if not found, and improve diagnostic output
@coveralls
Copy link

Pull Request Test Coverage Report for Build 112

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.286%

Totals Coverage Status
Change from base Build 109: 0.0%
Covered Lines: 123
Relevant Lines: 175

💛 - Coveralls

@bluca bluca merged commit 3c14d37 into zeromq:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants