Problem: Travis requires sudo and draft not enabled for git repo #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppzmq does not follow other zeromq projects where draft builds are enabled by default for git repository. Solution: revert back code where ENABLE_DRAFTS in set to ON if .git directory exists
sudo was required for for pkg-config libzmq build as cppzmq could not find not installed pkg-config libzmq. Solution: cppzmq to use cmake prefix paths for pkg config paths as well.
Pull Request Test Coverage Report for Build 108
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Travis requires sudo for for pkg-config libzmq build as cppzmq can not
find installed pkg-config libzmq in custom location.
Solution: cppzmq to use cmake prefix paths for pkg config paths.
Problem: cppzmq does not follow other zeromq projects where draft builds are
enabled by default for git repository.
Solution: revert back code where ENABLE_DRAFTS in set to ON if .git
directory exists