Problem: cppzmq build broken with C++11 compiler and git cloned repo. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default build, ./ci_build.sh without any arguments, which causes to run with draft disabled, does not work properly for git cloned repository and C++11 compiler. Two issues: 1. For git cloned repository ENABLE_DRAFTS is ON by default but libzmq compiled build without drafts .Travis did not catch that because default build runs on non C++11 compiler. 2. testutil.hpp does not build because of missing draft guards. Solution 1: Remove check for presence of .git for enabling draft API as it is confusing to use with ENABLE_DRAFTS flag and there should be only one explicit way to enable draft build. Solution 2: add missing draft guards in testutil.hpp for server/client socket in use there. Solution 3: add extra Travis build covering C++11 compiler and non draft enabled build.
Pull Request Test Coverage Report for Build 100
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 100
💛 - Coveralls |
bluca
reviewed
May 20, 2018
| @@ -19,11 +19,7 @@ if (ZeroMQ_FOUND AND (NOT TARGET libzmq OR NOT TARGET libzmq-static)) | |||
| message(FATAL_ERROR "ZeroMQ version not supported!") | |||
| endif() | |||
|
|
|||
| if (EXISTS "${CMAKE_SOURCE_DIR}/.git") | |||
There was a problem hiding this comment.
Note that this check is used by all other ZMQ projects which implement a draft system
There was a problem hiding this comment.
I see, in this case we can keep it consistent with others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default build, ./ci_build.sh without any arguments, which causes to run
with draft disabled, does not work properly for git cloned repository and
C++11 compiler.
Two issues:
compiled build without drafts .Travis did not catch that because default build
runs on non C++11 compiler.
Solution 1: Remove check for presence of .git for enabling draft API as it
is confusing to use with ENABLE_DRAFTS flag and there should be only one
explicit way to enable draft build. That fixes #235 wher draft was implicitly enabled.
Solution 2: add missing draft guards in testutil.hpp for server/client
socket in use there.
Solution 3: add extra Travis build covering C++11 compiler and non
draft build.