Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cppzmq needs to be installed for pkg-config libzmq #234

Merged
merged 2 commits into from
May 19, 2018

Conversation

kurdybacha
Copy link
Contributor

Solution: Make sure that FinZeroMQ.cmake is present in cppzmq's build
(binary) directory. That way cppzmq can be used from build/binary directory directly for all the cases.

Solution: Make sure that FinZeroMQ.cmake is present in cppzmq's build
(binary) directory
Solution: Change it to CI supported 4.2.0
@coveralls
Copy link

coveralls commented May 18, 2018

Pull Request Test Coverage Report for Build 97

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 54.688%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 2 61.97%
Totals Coverage Status
Change from base Build 95: 0.0%
Covered Lines: 35
Relevant Lines: 64

💛 - Coveralls

@bluca
Copy link
Member

bluca commented May 18, 2018

Can the sudo be removed from the Travis config file now?

@kurdybacha
Copy link
Contributor Author

not yet, we still need to install libzmq in pkg-config case.

@sigiesec sigiesec merged commit d487e67 into zeromq:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants