Problem: libzmq pkg-config build not covered by CI #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: build and install libzmq using autogen tools.
Solution: Move sudo required build to top to start sooner to get better overall build time.
It seems to be a problem with cppzmq where FindZeroMQ.cmake is not found without installing cppzmq. Solution: install cppzmq for pkg-config build type.
Solution: simplify Travis config file by defining default build options DRAFT and ZMQ_VERSION in ci_build.sh script
Pull Request Test Coverage Report for Build 94
💛 - Coveralls |
Pull Request Test Coverage Report for Build 94
💛 - Coveralls |
|
You can install to a local directory and avoid the sudo |
|
true, will change that. thanks. |
|
@bluca, not that easy as I thought. for some reason cppzmq does not compile with locally installed pkg-config version of libzmq. I would need to spend more time on that some other day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: libzmq pkg-config build (using autogen) added to Travis CI.
There is an issue with cppzmq where it needs to be installed as well in order to find pkg-config version of libzmq. That will be addressed in separate PR.