Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: whitespace style too restrictive. #228

Merged
merged 1 commit into from
May 12, 2018

Conversation

kurdybacha
Copy link
Contributor

For header only library like cppzmq, whitespace style inherited from
libzmq is too restrictive.

Solution: relaxing whitespace before parens from always to in control
statements only, increased max column width from 80 to 85 and removing
requirement of whitespace after template keyword.

For header only library like cppzmq, whitespace style inherited from
libzmq is too restrictive.

Solution: relaxing whitespace before parens from always to in control
statements only, increased max column width from 80 to 85 and removing
requirement of whitespace after template keyword.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 90

  • 22 of 37 (59.46%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.4%) to 54.688%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zmq.hpp 22 37 59.46%
Files with Coverage Reduction New Missed Lines %
zmq.hpp 1 61.97%
Totals Coverage Status
Change from base Build 89: -1.4%
Covered Lines: 35
Relevant Lines: 64

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 12, 2018

Pull Request Test Coverage Report for Build 90

  • 22 of 37 (59.46%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.4%) to 54.688%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zmq.hpp 22 37 59.46%
Files with Coverage Reduction New Missed Lines %
zmq.hpp 1 61.97%
Totals Coverage Status
Change from base Build 89: -1.4%
Covered Lines: 35
Relevant Lines: 64

💛 - Coveralls

@bluca bluca merged commit f81accd into zeromq:master May 12, 2018
@kurdybacha kurdybacha deleted the clang-format branch May 12, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants