Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: inconsistent code style #226

Merged
merged 4 commits into from
May 11, 2018
Merged

Conversation

kurdybacha
Copy link
Contributor

@kurdybacha kurdybacha commented May 11, 2018

Solution: copy .clang-format from libzmq as a starting point and run clang-format on the hpp/cpp files.

There is no need to follow exactly what libzmq does as this is header only library but it seems reasonable starting point. It would be good to stick to one style as there is a lot of activity and good ideas lately.
Build changes to follow.

Solution: copy .clang-format from `libzmq` as a starting point.

There is no need to follow exactly what libzmq does but it seems
reasonable starting point. It would be good to stick to one style as
there is a lot of activity and good ideas lately.
@coveralls
Copy link

coveralls commented May 11, 2018

Pull Request Test Coverage Report for Build 86

  • 33 of 61 (54.1%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 56.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zmq.hpp 32 60 53.33%
Files with Coverage Reduction New Missed Lines %
zmq.hpp 1 63.01%
Totals Coverage Status
Change from base Build 82: -0.9%
Covered Lines: 37
Relevant Lines: 66

💛 - Coveralls

@kurdybacha
Copy link
Contributor Author

please ignore coverage run with this changes as it is caused by line breaks. Column is now 80 as per clang-format.

@sigiesec
Copy link
Member

Great :) I wanted to apply the formatting myself for some time but did not find the time.

The coverage isn't working properly anyway, unfortunately., And I am not familiar with gcov :(

@sigiesec sigiesec merged commit bc82352 into zeromq:master May 11, 2018
@kurdybacha
Copy link
Contributor Author

kurdybacha commented May 12, 2018

What do you think about two style changes:
SpaceBeforeParens: Always -> SpaceBeforeParens: false
ColumnLimit: 80 -> ColumnLimit: 85 //as this is header only library and everyone has at least 21inch monitors now
btw I will take a look at coverage issue.

@sigiesec
Copy link
Member

For me that's fine. It's closer to my personal preferences anyway ;)

Thanks for giving the coverage a look. One thing is that the DRAFT parts seem to be completely ignored, they are neither shown as covered nor uncovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants