Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: design goals and supported platforms are not explicitly stated #224

Merged
merged 1 commit into from
May 11, 2018

Conversation

sigiesec
Copy link
Member

Solution: add section on design goals and supported platforms to README, improve overall structure of README

Solution: add section on design goals and supported platforms to README, improve overall structure of README
@coveralls
Copy link

coveralls commented May 11, 2018

Pull Request Test Coverage Report for Build 79

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+6.4%) to 62.667%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 2 64.38%
Totals Coverage Status
Change from base Build 78: 6.4%
Covered Lines: 47
Relevant Lines: 75

💛 - Coveralls

@bluca bluca merged commit fffd7bf into zeromq:master May 11, 2018
@sigiesec sigiesec deleted the add-design-goals branch May 11, 2018 12:29
Copy link
Contributor

@kurdybacha kurdybacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Btw where are the design goals coming from? I agree with them just would like to know if this has been discussed somewhere?

@sigiesec
Copy link
Member Author

Well, I extrapolated them from what was implemented, what impression I had what the goals might have been originally, and the reasons why we chose to use cppzmq.

If someone disagrees, we now have a basis for discussion. I could send a mail to the zeromq mailing list, asking for a discussion explicitly. What do you think about that?

@kurdybacha
Copy link
Contributor

Email seems reasonable, we might get some valuable inputs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants