Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: poller's constructor is not default generated #222

Merged
merged 1 commit into from
May 11, 2018
Merged

Problem: poller's constructor is not default generated #222

merged 1 commit into from
May 11, 2018

Conversation

kurdybacha
Copy link
Contributor

Solution: Constructor logic moved to the same place where cleanup is and
marking constructor default. Init/cleanup code is in one pleace making
it easier to read/maintain.

@kurdybacha
Problem: poller's constructor is not default
c03fb35 
Solution: Constructor logic moved to the same place where cleanup is and
marking constructor `default`. Init/cleanup code is in one pleace making
it easier to read/maintain.
@coveralls
Copy link

coveralls commented May 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 75

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 56.25%
Files with Coverage Reduction New Missed Lines %
zmq.hpp 2 64.38%
Totals Coverage Status
Change from base Build 74: 0.0%
Covered Lines: 36
Relevant Lines: 64
💛 - Coveralls

@sigiesec sigiesec merged commit cdef8bc into zeromq:master May 11, 2018
@kurdybacha kurdybacha deleted the poller-init branch May 11, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurdybacha @coveralls @sigiesec