Problem: poller move operations not complete #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest modification to the poller made move constructor and move assigment operator not complete. In order to prevent that in the future poller should be default movable. Unique pointer has been used to manager zmq_poller. That makes code simpler and safer now.
As disscussed on zeromq#219 PR bringing back `size` method and adding `empty` for completeness.
Pull Request Test Coverage Report for Build 73
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest poller's fixes in #219 left poller's move constructor and move assignment not updated and invalid.
Solution: In order to prevent this in the future make poller default movable, which results in simpler and safer API. Extra unit tests added to cover missed use cases for move operations.
Additionally bringing back
sizemethod and addedemptyfor completeness - as discussed in #219 . Unit tests updated.