Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message using empty version variable #220

Merged
merged 1 commit into from
May 8, 2018
Merged

Conversation

zguangyu
Copy link
Contributor

@zguangyu zguangyu commented May 8, 2018

project(cppzmq VERSION ${DETECTED_CPPZMQ_VERSION}) will create a variable called cppzmq_VERSION instead of CPPZMQ_VERSION. This is the case under cmake v3.9.4 .

@coveralls
Copy link

coveralls commented May 8, 2018

Pull Request Test Coverage Report for Build 71

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 56.25%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 2 64.38%
Totals Coverage Status
Change from base Build 70: 0.0%
Covered Lines: 36
Relevant Lines: 64

💛 - Coveralls

@kurdybacha
Copy link
Contributor

Looks good to me. Thanks @zguangyu for providing the PR.

@bluca bluca merged commit 3281509 into zeromq:master May 8, 2018
@zguangyu zguangyu deleted the patch-1 branch May 8, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants