Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Missing QUIET option causes a CMake warning #218

Merged
merged 1 commit into from
May 2, 2018

Conversation

kleisauke
Copy link
Contributor

When libzmq is installed via a package manager, it causes a CMake warning when building cppzmq, which can be safely ignored.

There's no behavior change with this patch, because when libzmq isn't installed it will still raise a warning (find_package(ZeroMQ REQUIRED) is called a few lines further).

When libzmq is installed via a package manager, it causes a CMake warning when building cppzmq, which can be safely ignored.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 66

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 56.25%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 2 64.38%
Totals Coverage Status
Change from base Build 65: 0.0%
Covered Lines: 36
Relevant Lines: 64

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 2, 2018

Pull Request Test Coverage Report for Build 66

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 56.25%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 2 64.38%
Totals Coverage Status
Change from base Build 65: 0.0%
Covered Lines: 36
Relevant Lines: 64

💛 - Coveralls

@bluca bluca merged commit ac64eba into zeromq:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants