Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: googletest is also installed into install destination #217

Merged
merged 1 commit into from
Apr 29, 2018

Conversation

kurdybacha
Copy link
Contributor

Building and installing cppzmq brings googletest build artifacts to the
installation destination as well. For example someone building cppzmq
with:

cmake -DCMAKE_INSTALL_PREFIX=mydest .
cmake --build --target install

gets googletest headers and libraries in mydest.

Solution: remove googletest from install target

Building and installing cppzmq brings googletest build artifacts to the
installation destination as well. For example someone building cppzmq
with:
```
cmake -DCMAKE_INSTALL_PREFIX=mydest .
cmake --build --target install
```
gets googletest headers and libraries in `mydest`.

Solution: remove googletest from install target
@coveralls
Copy link

coveralls commented Apr 29, 2018

Pull Request Test Coverage Report for Build 64

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 56.25%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 2 64.38%
Totals Coverage Status
Change from base Build 63: 0.0%
Covered Lines: 36
Relevant Lines: 64

💛 - Coveralls

@c-rack c-rack merged commit 13bf7fd into zeromq:master Apr 29, 2018
@kurdybacha kurdybacha deleted the cmake_install branch May 2, 2018 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants