Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tests and implementation of message_t #205

Merged
merged 6 commits into from
Apr 16, 2018

Conversation

sigiesec
Copy link
Member

See individual commits

Solution: split up into test cases for various ctors and equality operators
Solution: implemented equals using operator==
… temporary copies of both operands

Solution: implement operator== using memcmp instead
Solution: added test cases
Solution: simplified code
@coveralls
Copy link

Pull Request Test Coverage Report for Build 28

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 57.576%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 4 65.33%
Totals Coverage Status
Change from base Build 25: -0.9%
Covered Lines: 38
Relevant Lines: 66

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 28

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.9%) to 57.576%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 4 65.33%
Totals Coverage Status
Change from base Build 25: -0.9%
Covered Lines: 38
Relevant Lines: 66

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 16, 2018

Pull Request Test Coverage Report for Build 29

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.2%) to 56.25%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 4 64.38%
Totals Coverage Status
Change from base Build 25: -2.2%
Covered Lines: 36
Relevant Lines: 64

💛 - Coveralls

@bluca bluca merged commit 19da7a4 into zeromq:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants