Problem: poller's handler not aware of event type. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to register a handler for more than one event types but impossible to distinguish which event is being handled. Now events are passed to a handler. Besides that some other changes: * new test covering changes in the poller * modified existing tests to cover changes in the poller * defined handler_t in poller_t scope for more convinient use and simpler code * helper loopback binder to be re-used in tests
Issue #199 It seems that with GCC on Linux <array> is implicitly included by one of stl includes already in zmq.hpp but it breaks on Windows with Visual Studio. Adding explicit include for array. Can not verify right now but this change is a good practice so creating a pull request.
sigiesec
reviewed
Apr 9, 2018
| void add (zmq::socket_t &socket, short events, std::function<void(void)> &handler) | ||
| using handler_t = std::function<void(short)>; | ||
|
|
||
| void add (zmq::socket_t &socket, short events, handler_t &handler) |
There was a problem hiding this comment.
This should be done in a backwards-compatible way, i.e. keep a function with the old signature that wraps a std:: function<void(void)> and passes it to the function with the new signature.
There was a problem hiding this comment.
thank you for review. this is draft so no need for that.
There was a problem hiding this comment.
Right. Since it is related to a libzmq draft api, it can be regarded draft in cppzmq as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to register a handler for more than one event types but
impossible to distinguish which event is being handled.
Now events are passed to a handler.
Besides that some other changes:
and simpler code