Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some initial tests, add some build/version CI variants #194

Merged
merged 7 commits into from
Apr 3, 2018

Conversation

sigiesec
Copy link
Member

@sigiesec sigiesec commented Apr 3, 2018

No description provided.

Solution: added a few initial test cases
@coveralls
Copy link

coveralls commented Apr 3, 2018

Pull Request Test Coverage Report for Build 6

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+54.8%) to 54.839%

Files with Coverage Reduction New Missed Lines %
zmq.hpp 14 58.97%
Totals Coverage Status
Change from base Build 4: 54.8%
Covered Lines: 17
Relevant Lines: 31

💛 - Coveralls

@bluca
Copy link
Member

bluca commented Apr 3, 2018

@sigiesec could you please rebase and remove tests/example_add.o ? otherwise it will stay in the repo forever as it's a binary file

@bluca
Copy link
Member

bluca commented Apr 3, 2018

Also why don't we get the coveralls messages on the libzmq repo? I'm pretty sure I set that up, and we used to at some point

Solution: build tests within cppzmq build, and add separate demo
Solution: add travis job with libzmq 4.2.0
Solution: move and split example_add.cpp
Solution: stop bash on first error
Solution: added initial test case
@sigiesec
Copy link
Member Author

sigiesec commented Apr 3, 2018

@bluca Oops, good you noticed that. The object file should be gone now.

I don't know why the coverage report isn't working. I also think I remember that it worked in libzmq some time ago. On the other hand, I don't know why it works here. I did nothing special to get it comment here. Probably it is some kind of permission problem? (However, the coverage isn't correct. It shows lines as non-executed, which must definitely have been executed, and some others are completely missing. I don't know why, but I fear I cannot analyze this deeply soon)

@sigiesec
Copy link
Member Author

sigiesec commented Apr 3, 2018

@bluca Could you also give me permissions on cppzmq such that I can edit the issue labels?

@bluca
Copy link
Member

bluca commented Apr 3, 2018

you should have the invitation

@bluca bluca merged commit 5ebc7fe into zeromq:master Apr 3, 2018
@sigiesec
Copy link
Member Author

sigiesec commented Apr 3, 2018

@bluca Yes, thanks a lot :)

@sigiesec sigiesec deleted the add-initial-tests branch April 3, 2018 17:18
@bluca
Copy link
Member

bluca commented Apr 3, 2018

no problem, thanks for taking care of this repository, it desperately needed some attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants