-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some initial tests, add some build/version CI variants #194
Conversation
Solution: added a few initial test cases
Pull Request Test Coverage Report for Build 6
💛 - Coveralls |
@sigiesec could you please rebase and remove tests/example_add.o ? otherwise it will stay in the repo forever as it's a binary file |
Also why don't we get the coveralls messages on the libzmq repo? I'm pretty sure I set that up, and we used to at some point |
Solution: build tests within cppzmq build, and add separate demo
Solution: add travis job with libzmq 4.2.0
Solution: move and split example_add.cpp
Solution: added test case
Solution: stop bash on first error
Solution: added initial test case
f154f52
to
cc5f405
Compare
@bluca Oops, good you noticed that. The object file should be gone now. I don't know why the coverage report isn't working. I also think I remember that it worked in libzmq some time ago. On the other hand, I don't know why it works here. I did nothing special to get it comment here. Probably it is some kind of permission problem? (However, the coverage isn't correct. It shows lines as non-executed, which must definitely have been executed, and some others are completely missing. I don't know why, but I fear I cannot analyze this deeply soon) |
@bluca Could you also give me permissions on cppzmq such that I can edit the issue labels? |
you should have the invitation |
@bluca Yes, thanks a lot :) |
no problem, thanks for taking care of this repository, it desperately needed some attention |
No description provided.