New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy/move constructors of poller_t, and make error handling consistent with rest of API #190

Merged

bluca merged 2 commits into zeromq:master from sigiesec:fix-poller-api-error-handling

Mar 26, 2018

Member

sigiesec commented Mar 26, 2018

See individual commits for details.

sigiesec added 2 commits

March 26, 2018 16:58


          Problem: poller_t is copyable, but does not implement copying properly

16a7651

Solution: make poller_t non-copyable, but properly movable


          Problem: inconsistent error handling in poller_t

Solution: make poller_t::add and poller_t::remove throw error_t on error, return void

bluca merged commit 52c606e into zeromq:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment