Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zmq.hpp #135

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Update zmq.hpp #135

merged 1 commit into from
Jul 17, 2017

Conversation

juseless
Copy link
Contributor

Line 706 constructor was:
monitor_t() : socketPtr(NULL), monitor_socket{NULL} {}
but should be:
monitor_t() : socketPtr(NULL), monitor_socket(NULL) {}

Note change of bracket types for monitor_socket parameter.

Line 706 constructor was:   
monitor_t() : socketPtr(NULL), monitor_socket{NULL} {}
but should be:
monitor_t() : socketPtr(NULL), monitor_socket(NULL) {}

Note change of bracket types for monitor_socket parameter.
@mwpowellhtx
Copy link

mwpowellhtx commented Jul 17, 2017 via email

@bluca
Copy link
Member

bluca commented Jul 17, 2017

Thanks.
@a4z FYI

@bluca bluca merged commit 749522d into zeromq:master Jul 17, 2017
@bluca
Copy link
Member

bluca commented Jul 17, 2017

@juseless for your next PRs please use the following format for commit messages:

Problem: X is broken

Solution: do Y and Z to fix X

@a4z
Copy link
Contributor

a4z commented Jul 17, 2017

thanks, after 6 years of C++11, using single brace-enclosed initializer became so natural ...

@ax3l ax3l mentioned this pull request Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants