Skip to content

Commit

Permalink
Merge pull request #373 from gummif/gfa/tostring
Browse files Browse the repository at this point in the history
Problem: message_t to string is hard
  • Loading branch information
sigiesec committed Jan 9, 2020
2 parents de07119 + 4f9c2ea commit bd27f24
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 3 deletions.
12 changes: 12 additions & 0 deletions tests/message.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,18 @@ TEST_CASE("message equality non equal lhs empty", "[message]")
CHECK(msg_a != msg_b);
}

TEST_CASE("message to string", "[message]")
{
const zmq::message_t a;
const zmq::message_t b("Foo", 3);
CHECK(a.to_string() == "");
CHECK(b.to_string() == "Foo");
#ifdef ZMQ_CPP17
CHECK(a.to_string_view() == "");
CHECK(b.to_string_view() == "Foo");
#endif
}

#if defined(ZMQ_BUILD_DRAFT_API) && ZMQ_VERSION >= ZMQ_MAKE_VERSION(4, 2, 0)
TEST_CASE("message routing id persists", "[message]")
{
Expand Down
22 changes: 19 additions & 3 deletions zmq.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -552,9 +552,25 @@ class message_t
}
#endif

/** Dump content to string. Ascii chars are readable, the rest is printed as hex.
* Probably ridiculously slow.
*/
// interpret message content as a string
std::string to_string() const
{
return std::string(static_cast<const char*>(data()), size());
}
#ifdef ZMQ_CPP17
// interpret message content as a string
std::string_view to_string_view() const noexcept
{
return std::string_view(static_cast<const char*>(data()), size());
}
#endif

/** Dump content to string for debugging.
* Ascii chars are readable, the rest is printed as hex.
* Probably ridiculously slow.
* Use to_string() or to_string_view() for
* interpreting the message as a string.
*/
std::string str() const
{
// Partly mutuated from the same method in zmq::multipart_t
Expand Down

0 comments on commit bd27f24

Please sign in to comment.