Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added myself to contributor's list #22502

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

rewpolo
Copy link
Contributor

@rewpolo rewpolo commented May 29, 2024

No description provided.

Copy link
Contributor

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

Copy link
Contributor

⚠️ MERGE CONFLICT DETECTED!

@rewpolo A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
Copy link
Contributor

⚠️ MERGE CONFLICT DETECTED!

@rewpolo A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@rewpolo
Copy link
Contributor Author

rewpolo commented May 29, 2024

I ran git pull master origin and recommitted

CONTRIBUTORS.md Outdated
@@ -42,7 +45,7 @@

- [Harun Adil](https://github.com/HarunAdil)

_ [Ramon R](https://github.com/artboycat)
\_ [Ramon R](https://github.com/artboycat)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have mistake regarding writing your name in contributor list, you need use "-" this character while writing your name and use "" character
Screenshot 2024-05-31 210044

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this changes or you can follow instructions

CONTRIBUTORS.md Outdated
@@ -42,7 +45,7 @@

- [Harun Adil](https://github.com/HarunAdil)

_ [Ramon R](https://github.com/artboycat)
\_ [Ramon R](https://github.com/artboycat)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this changes or you can follow instructions

Copy link
Contributor

🙏 Thanks for your pull request @rewpolo, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
22502 3 12
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 2574 16925

1 similar comment
Copy link
Contributor

🙏 Thanks for your pull request @rewpolo, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
22502 3 12
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 2574 16925

@LaurelineP LaurelineP merged commit 3797b8b into zero-to-mastery:master Jun 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants