Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added - username to contributors.md #963

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

pawaspy
Copy link
Member

@pawaspy pawaspy commented Oct 20, 2023

No description provided.

@zero-to-mastery-bot
Copy link

🙏 Thanks for your pull request @pawaspy, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
963 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 2379 1072

@sophiabrandt
Copy link
Member

@pawaspy Please point to the the pull request where you contributed to this repository.

Just adding your contributor's name doesn't constitute as something we can accept to this repo.

So if you have already added a link or contributed otherwise, please comment with a reference. Thank you.

@sophiabrandt sophiabrandt added the question Further information is requested label Nov 11, 2023
Copy link

⚠️ MERGE CONFLICT DETECTED!

@pawaspy A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

2 similar comments
Copy link

⚠️ MERGE CONFLICT DETECTED!

@pawaspy A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

Copy link

⚠️ MERGE CONFLICT DETECTED!

@pawaspy A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

Copy link

🙏 Thanks for your pull request @pawaspy, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
963 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 2387 1075

1 similar comment
Copy link

🙏 Thanks for your pull request @pawaspy, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
963 1 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 2387 1075

@pawaspy
Copy link
Member Author

pawaspy commented Nov 11, 2023

@sophiabrandt
Copy link
Member

@pawaspy Thanks! 🙏

@sophiabrandt sophiabrandt merged commit 54cd9ae into zero-to-mastery:master Nov 11, 2023
sophiabrandt added a commit that referenced this pull request Nov 11, 2023
sophiabrandt added a commit that referenced this pull request Nov 11, 2023
@sophiabrandt
Copy link
Member

@pawaspy uuuh. Just realized that your contributions were to other repos than this one.

The Contributors.md is only meant for this specific repo.
Feel free to contribute to this one (https://github.com/zero-to-mastery/resources/), and add your name to the CONTRIBUTORS.md of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants