build: switched to .prettierrcjson with default config from documenta… #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion It seems like using the `.prettierrc` file doesn't work reliably, as I've seen a pull request that changed files but didn't trigger the lint-staged script (with prettier). When I manually run the prettier script, it also does not consider the `semi:false`. Using `.prettierrc.json` seems to work, and it also has the advantage of being a `.json` file, so it can be formatted and displayed nicely.
|
🙏 Thanks for your pull request @sophiabrandt, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
I copied the configuration from the prettier documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion
It seems like using the
.prettierrcfile doesn't work reliably, as I've seen a pull request that changed files but didn't trigger the lint-staged script (with prettier). When I manually run the prettier script, it also does not consider thesemi:false.Using
.prettierrc.jsonseems to work, and it also has the advantage of being a.jsonfile, so it can be formatted and displayed nicely.